search

opencast-ilias / OpenCast

Opencast plugin for ILIAS LMS. The plugin shows a Opencast series as an ILIAS object. This version of the ILIAS plugin for Opencast is operated and developed collaboratively by a community. The University of Bern acts as coordinative maintainer.
GNU General Public License v3.0
12 stars 14 forks source link

Memorization of last position in video is not per video #289

Closed mic-men closed 3 weeks ago

mic-men commented 1 month ago

Describe the bug When leaving the Paella Player in the middle of a video, the last position is remembered. Unfortunately this position is not remembered per video, i.e. when playing another video afterwards it starts from the remembered position of the last one.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Play' for a video
  2. The player with the thumbnail is visible. Now click the Play button.
  3. Play some time, pause the video, remember the time stamp the video has stopped.
  4. Leave video and open another one for playing.
  5. The player with the thumbnail is visible. Now click the Play button.
  6. The new video starts from the time position the previous one has been left.

Expected behavior A new video should play right from the start resp. the position I left exactly this video the last time.

Environment (please complete the following information):

Note Until there is a solution a certain flag in the config.json of the player should be set to false. Unfortunately I do not know which one, please someone else add this info!

mic-men commented 1 month ago

In order to disable this buggy feature, set

"restoreLastTime": { "enabled": false,

in config.json See here.

dagraf commented 3 weeks ago

@chfsx Is this a bug you would fix or should we ask @ferishili to do so, since it concerns the Paella player?

ferishili commented 3 weeks ago

I will take care of it

dagraf commented 3 weeks ago

After pulling https://github.com/opencast-ilias/OpenCast/pull/295 (for Release 8), the bug no longer exists. I therefore close this issue.

@mic-men Can you please test the PR https://github.com/opencast-ilias/OpenCast/pull/296 for Release 7? Thx!

mwizgall commented 3 weeks ago

After pulling #295 (for Release 8), the bug no longer exists. I therefore close this issue.

@mic-men Can you please test the PR #296 for Release 7? Thx!

After pulling #295 (for Release 8), the bug no longer exists. I therefore close this issue.

@mic-men Can you please test the PR #296 for Release 7? Thx!

@dagraf Michael has updated the plugin recently and I tested it afterwards. The issue still exists for ILIAS v7.30.1.

ferishili commented 3 weeks ago

Make sure that your browser cache is clear

mwizgall commented 3 weeks ago

@ferishili If I compare two different Videos the problem still exists.

  1. Video 1 starts at 00:00.
  2. Video 2 starts at the point Video 1 ended.
  3. I clear the browser cache
  4. The first Video I open (Video 1 e.g. ), starts at 00:00 as it should.
  5. Unfortunately Video 2 starts at the position I left Video 1 in step 4.
ferishili commented 3 weeks ago

We need to look deeper into this problem, it appears that disabling the config restoreLastTime is not enough!

reiferschris commented 3 weeks ago

Hey @mwizgall could you please check the contents of your config.json after clearing the cache in your browsers dev-tools? They should appear in the network tab where you can see the response and the contents of that file

mwizgall commented 1 week ago

Hey @reiferschris,

thank's for your help. Unfortunately I couldn't find the requested information. I don't have admin access on our system, so I just have the information from Michael, that the plugin has been updated.

The network-tab in Google and Firefox (After clearing the cache and accessing ILIAS + Paella player twice) doesn't contain the communication with the 'config.json' (Screenshot 1/2). In the search for the debugger I found the config.json (Screenshot 3/4), but I dont think that the information is helpful.

DevTools DevTools_Firefox Config js Network-Tab

Could you give me a more detailed advise, how I can find the neccessary information?

reiferschris commented 1 day ago

Hi @mwizgall try this please:

  1. Open a video in a new tab
  2. Open the dev tools, network tab
  3. search for the check box "disable cache" or something like that (both firefox and chrome have this option)
  4. reload the page, ideally delete the history in the dev tools before that to see only the traffic after the reload.