Too much unnecessary subtitle details in paella player

opencast-ilias / OpenCast

Opencast plugin for ILIAS LMS. The plugin shows a Opencast series as an ILIAS object. This version of the ILIAS plugin for Opencast is operated and developed collaboratively by a community. The University of Bern acts as coordinative maintainer.

GNU General Public License v3.0

12 stars 14 forks source link

Too much unnecessary subtitle details in paella player #292

Closed ferishili closed 3 weeks ago

ferishili commented 4 weeks ago

Description

The subtitle names in the ILIAS paella player shows unnecessary details of the captions (when they have tag details) devided by "-" e.g. eng - (Manual) - (Subtitle) which does not match the Opencast paella player that only shows the language name!

To Reproduce Steps to reproduce the behavior:

Make sure you have a video that has captions (subtitles) using new mechanism with tags
Play that video in ILIAS and check the caption name
Play that video in Opencast and check the caption name there

Expected behavior The ILIAS paella player should provide only the language name just like paella player in opencast.

Environment (please complete the following information):

ILIAS version: v7 or v8
Plugin version: release_7 & release_8 are affected
Opencast version 15 (must)
Browser: all

reiferschris commented 4 weeks ago

Hi, I don't think this data is unnecessary. It can and IMHO should be used at least partially to indicate e.g. that a subtitle was generated by whisper/automated. We specifically added this when developing the feature to show subtitles to tell the user about the quality of the subtitles, so they can adjust their expectations. I'm strongly against removing that as a feature, I'm not opposed however to make it configurable which parts of the tags are shown .

ferishili commented 4 weeks ago

+1 configurable @dagraf what do you think?

reiferschris commented 4 weeks ago

See for example youtube where they show how the subtitle was generated:

dagraf commented 3 weeks ago

I agree, the information is not unnecessary. Therefore, the goal of fixing this issue should not be to only show the language name but show all relevant information in a suitable form. See for example the same video played in Opencast (above) and in ILIAS (below). I would expect the paella player in ILIAS to show the information in the same way as it is shown in the paella player in Opencast.

Opencast:

ILIAS:

dagraf commented 3 weeks ago

After pulling https://github.com/opencast-ilias/OpenCast/pull/295 (for Release 8), the bug no longer exists. I therefore close this issue.