opencast-ilias / OpenCast

Opencast plugin for ILIAS LMS. The plugin shows a Opencast series as an ILIAS object. This version of the ILIAS plugin for Opencast is operated and developed collaboratively by a community. The University of Bern acts as coordinative maintainer.
GNU General Public License v3.0
12 stars 14 forks source link

Download of video by a right click should not be possible #293

Closed dagraf closed 3 weeks ago

dagraf commented 3 weeks ago

Describe the bug With Paella 7, the videos can be downloaded using the right click and then "Save video". This should not be the case.

To Reproduce Steps to reproduce the behavior:

  1. Open a video
  2. Make a right click
  3. Choose "Save video as"

Expected behavior It should not be possible to download the video that easily. Possible solution: The right click

Environment (please complete the following information):

Additional context It might be a solution, to make changes in paella-player.js (under: Prevent video download).

dagraf commented 3 weeks ago

Same question as in https://github.com/opencast-ilias/OpenCast/issues/289:

@chfsx Is this a bug you would fix or should we ask @ferishili to do so, since it concerns the Paella player?

ferishili commented 3 weeks ago

Since it is Paella related, I will take a look, but not sure if that is easy to prevent

dagraf commented 3 weeks ago

It is prevented in Paella 7 on our Opencast 15 we run on our Test-Opencast.

reiferschris commented 3 weeks ago

Paella docs regarding this are here: https://paellaplayer.upv.es/#/doc/mp4_video_plugin.md @dagraf have you implemented this change from the docs? Or are you referring to the fact that you don't use mp4 but instead stream via hls?

dagraf commented 3 weeks ago

Paella docs regarding this are here: https://paellaplayer.upv.es/#/doc/mp4_video_plugin.md @dagraf have you implemented this change from the docs? Or are you referring to the fact that you don't use mp4 but instead stream via hls?

@snoesberger: Can you answer @reiferschris question?

snoesberger commented 3 weeks ago

Paella docs regarding this are here: https://paellaplayer.upv.es/#/doc/mp4_video_plugin.md @dagraf have you implemented this change from the docs? Or are you referring to the fact that you don't use mp4 but instead stream via hls?

In Opencast this can easily be configured with the preventVideoDownloadparameter in the Paella config file config.json. Setting this parameter to true will disable the right click menu in the player. It doesn't matter if you use mp4 or hls.

dagraf commented 3 weeks ago

After pulling https://github.com/opencast-ilias/OpenCast/pull/295 (for Release 8), the bug no longer exists. I therefore close this issue.