search

opencast-ilias / OpenCast

Opencast plugin for ILIAS LMS. The plugin shows a Opencast series as an ILIAS object. This version of the ILIAS plugin for Opencast is operated and developed collaboratively by a community. The University of Bern acts as coordinative maintainer.
GNU General Public License v3.0
13 stars 14 forks source link

Misspelled Opencast #30

Open lkiesow opened 2 years ago

lkiesow commented 2 years ago

Can we change the repository name? Opencast is misspelled. It's not written with a capitalized C.

mtneug commented 2 years ago

@ebbertd can you comment on that?

ebbertd commented 2 years ago

First, I totally agree with the issue and would also like to see this changed.

As for actually changing it. As far as I know this would break the installation of current users after an update as ILIAS expected the name to stay the same. I hope @Amstutz can explain this better.

okaufman commented 2 years ago

Already existing installations would need to change the name of their folder under plugins/Services/Repository/RepositoryObject/OpenCast manually, because a simple "git pull" will not update the name of the folder.

If we change the name of the repository, we also have to change the spelling of the classnames in the classes-folder.

mtneug commented 2 years ago

There is already a PR for this in one of the upstream repos.

Amstutz commented 2 years ago

I think we have bigger fish to fry, atm. I see much more pain than gain here. Note that also classes need to be renamed.

Note that this is not visible to end users, since we adapt the name through language variables. If anybody is willing to write a PR, which covers all necessary refactorings in all the code. We could test it. I close this. Please don't hesitate to reopen if we find a volunteer we could assign this to.

ebbertd commented 2 years ago

I created a PR for this. See #31