[Release 7] Avoid unnecessary ACL update when updating series metadata

opencast-ilias / OpenCast

Opencast plugin for ILIAS LMS. The plugin shows a Opencast series as an ILIAS object. This version of the ILIAS plugin for Opencast is operated and developed collaboratively by a community. The University of Bern acts as coordinative maintainer.

GNU General Public License v3.0

13 stars 14 forks source link

[Release 7] Avoid unnecessary ACL update when updating series metadata #321

Closed ferishili closed 2 months ago

ferishili commented 3 months ago

This PR fixes #297,

Description

please refer to the issue

Solution

It records the ACLs before applying the changes.
Gets the ACLs again after applying the changes.
Compare the old and new ACLs record sets, and perform the updateACL against the Opencast only when those changes are not equal.

This solution improves the logic as well as performance by avoiding unnecessary API call every time updating series metadata.

dagraf commented 3 months ago

If I got it right in our yesterdays meeting, this PR was already successfully tested by @tscheere.

Therefore, as soon as the other bigger PRs got merged this PR is ready to be reviewed and merged.

dagraf commented 2 months ago

@tscheere tested the release 8 version of this PR.

Therefore and @ferishili: Can you please prepare this PR for merging and when done contact @chfsx? Thx!