search

opencast-ilias / OpenCast

Opencast plugin for ILIAS LMS. The plugin shows a Opencast series as an ILIAS object. This version of the ILIAS plugin for Opencast is operated and developed collaboratively by a community. The University of Bern acts as coordinative maintainer.
GNU General Public License v3.0
13 stars 14 forks source link

Code-Style #36

Open chfsx opened 2 years ago

chfsx commented 2 years ago

The Opencast-Plugin uses a legacy code-style which is not really defined. I suggest to have PSR-2 + X as the ILIAS-Core uses it. I can provide a PR which changes the style for all classes but this will lead to break all currently open PRs.

Infos for PSR-2 + X: https://github.com/ILIAS-eLearning/ILIAS/blob/release_7/docs/development/coding-style.md

ebbertd commented 2 years ago

Given that there are not many PRs I don't think that is much of an issue.

reiferschris commented 2 years ago

Could we also add this code style check to github actions? Do you have any prior experience for setting that up?

chfsx commented 2 years ago

First part see #48

chfsx commented 2 years ago

Implemented in #62

chfsx commented 2 years ago

New PR in #69