opencast-ilias / OpencastPageComponent

Opencast plugin for ILIAS LMS page editor (dependent on https://github.com/opencast-ilias/OpenCast). This version of the ILIAS plugin for Opencast is operated and developed collaboratively by a community. The University of Bern acts as coordinative maintainer.
GNU General Public License v3.0
4 stars 6 forks source link

Release 7 & 8: Deselection columns has no effect when inserting a video #27

Closed dagraf closed 2 months ago

dagraf commented 7 months ago

Describe the bug Deselection of shown columns has no effect. After clicking on "Refresh", all columns are still shown and when opening the associated modal the columns that should not appear anymore are still selected.

To Reproduce Steps to reproduce the behavior:

  1. Insert a Opencast video using the page editor (Customise page > + > Insert Opencast Video)
  2. Click on 'Columns'
  3. Deactivate one ore more of the columns an hit on 'Refresh'
  4. See that all columns still get shown
  5. Click on 'Columns' again > See tat all collumns are still selected

Expected behavior When selecting columns they should not appear anymore in the table.

Screenshots

Before clicking "Refresh"

Bildschirmfoto 2024-03-25 um 14 53 10

After clicking "Refresh"

Bildschirmfoto 2024-03-25 um 14 53 20

Environment (please complete the following information):

Additional context Bug appears in release_7 and release_8.

dagraf commented 7 months ago

@chfsx: Could you please take a look at this bug and fix it if possible? Thx!

rfcmaXi commented 3 months ago

If it is useful: I can confirm the error with the OC plugin version v8.1.3 and the current PageComponent version :)

dagraf commented 2 months ago

With https://github.com/opencast-ilias/OpencastPageComponent/pull/28 there are no longer selectable columns for the moment (this could be possible in a future version again). Therefore, I close this issue. Feel free to open a new issue if you would want the columns to be selectable again.