Closed ferishili closed 3 weeks ago
This pull request is deployed at test.admin-interface.opencast.org/659/2024-06-06_13-19-23/ . It might take a few minutes for it to become available.
Use docker
or podman
to test this pull request locally.
Run test server using develop.opencast.org as backend:
podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-659
Specify a different backend like stable.opencast.org:
podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-659
It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md
.
I can get a saved filter to be displayed in the list anymore, if i close the edit menu with the x button: Bildschirmaufzeichnung vom 2024-06-06, 14-01-34.webm
Thanks, I will fix it. That faulty behavior was meant to be fixed as well.
This PR fixes #618,
As it is stated in issue, this wizard/dialog doesn't behave as it should specially when clicking cancel button (it closes the dialog and in edit mode removes the profile) => that is no go!
This PR fixes this bad behavior by bringing the
currentlyEditing
variable to live once again and set its type asFilterProfile
or null. So oncancelEditProfile
we now only check if it was in editing mode and create a record of that instead of letting it be removed for good!NOTE: A new translation key under "TABLE_FILTERS > PROFILES > ADD" is added. which replace the save text on the button when in adding new profile mode!
Apart from that, the style of the form in add/edit mode gets a proper look now!