Solve problems with accessibility in tables

opencast / opencast-admin-interface

A modern admin user interface for Opencast

https://admin-interface.opencast.org

Educational Community License v2.0

1 stars 22 forks source link

Solve problems with accessibility in tables #670

Closed rlucke closed 1 week ago

rlucke commented 3 weeks ago

add aria-label to table actions
keep title attr as a tooltip for the unlabeled icon buttons
add aria-label and group to pagination

Unfortunately, the table filter buttons are sometimes read out more and sometimes less well in different browsers with different screen readers. Adding an aria label may only make things worse.

fix #620

github-actions[bot] commented 3 weeks ago

Hi @rlucke Thank you for contributing to the Opencast Editor. We noticed that you have not yet filed an Individual Contributor License Agreement. Doing that (once) helps us to ensure that Opencast stays free for all. If you make your contribution on behalf of an institution, you might also want to file a Corporate Contributor License Agreement (giving you as individual contributor a bit more security as well). It can take a while for this bot to find out about new filings, so if you just filed one or both of the above do not worry about this message! Please let us know if you have any questions regarding the CLA.

EDIT(@lkiesow): The ICLA has been filed. Thanks. It may take some time for Apereo to process the ICLA. Feel free to ignore this complaint for now and point others to this comment if anyone asks.

github-actions[bot] commented 3 weeks ago

This pull request is deployed at test.admin-interface.opencast.org/670/2024-06-06_13-05-54/ . It might take a few minutes for it to become available.

github-actions[bot] commented 3 weeks ago

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-670

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-670

It may take a few seconds for the interface to spin up. It will then be available at http://127.0.0.1:3000. For more options you can pass on to the proxy, take a look at the README.md.

github-actions[bot] commented 3 weeks ago

This pull request has conflicts ☹ Please resolve those so we can review the pull request. Thanks.