search

opencast / opencast-admin-interface

A modern admin user interface for Opencast
https://admin-interface.opencast.org
Educational Community License v2.0
1 stars 22 forks source link

Center tooltips on main menu items #688

Closed lkiesow closed 3 weeks ago

lkiesow commented 3 weeks ago

The tooltips on the main menu items start really far away from the icons. This patch makes them activate only on the icon.

github-actions[bot] commented 3 weeks ago

This pull request is deployed at test.admin-interface.opencast.org/688/2024-06-09_12-36-50/ . It might take a few minutes for it to become available.

github-actions[bot] commented 3 weeks ago

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-688

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-688

It may take a few seconds for the interface to spin up. It will then be available at http://127.0.0.1:3000. For more options you can pass on to the proxy, take a look at the README.md.

stefanosgeo commented 3 weeks ago

It does what it should, but there are (?) issues. For example when using the dev tools for responsive design, the tooltips are still not aligned properly. Additionally, from the screenshot(text "Event" overlapping with status tabs, it appears there are other problems as well.

Screenshot from 2024-06-10 11-54-20

lkiesow commented 3 weeks ago

You are absolutely right. Can you file the responsive design problems as separate issues? This pull request just aims to be a small improvement for the tooltips in the main menu. Adressing the overlapping texts on small screens is likely a bit more work.

stefanosgeo commented 3 weeks ago

You are absolutely right. Can you file the responsive design problems as separate issues? This pull request just aims to be a small improvement for the tooltips in the main menu. Adressing the overlapping texts on small screens is likely a bit more work.

I will. Then this PR addresses and fixes the described problem.

lkiesow commented 3 weeks ago

Thanks for reviewing this. Since it was reviewed and later discussed at the technical meeting, I'm merging this.