opencast / opencast-admin-interface

A modern admin user interface for Opencast
https://admin-interface.opencast.org
Educational Community License v2.0
1 stars 23 forks source link

All metadata should be in the metadata step of the add event wizard #691

Open lkiesow opened 3 months ago

lkiesow commented 3 months ago

The “source” step of the add event wizard also contains metadata. This doesn't really make sense since there is a whole step dedicated to metadata. We should move “Start date” in there.

This fixes #487

github-actions[bot] commented 3 months ago

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-691

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-691

It may take a few seconds for the interface to spin up. It will then be available at http://127.0.0.1:3000. For more options you can pass on to the proxy, take a look at the README.md.

github-actions[bot] commented 3 months ago

This pull request is deployed at test.admin-interface.opencast.org/691/2024-07-23_23-06-17/ . It might take a few minutes for it to become available.

mtneug commented 3 months ago

Two other fields missing are "location" and "duration" (used for calculating the end date in the Admin UI). I set this for file uploads if I know these files are from a recording (e.g. CA did the recording, but editing was done locally). Is this in the scope of this PR, or should I create another issue?

lkiesow commented 3 months ago

You mean, you want these two additional fields in the recording metadata section? I think that's unrelated enough to not wait for that when merging this pull request. Nevertheless, I'll try taking a peek at the issue since I now kind of know the code and I hope it's not too hard to do.

mtneug commented 3 months ago

You mean, you want these two additional fields in the recording metadata section? I think that's unrelated enough to not wait for that when merging this pull request. Nevertheless, I'll try taking a peek at the issue since I now kind of know the code and I hope it's not too hard to do.

Fair. I created issue #742 to track this.

lkiesow commented 2 months ago

Fixed the minor issues and merged the different metadata sections. Now they shouldn't seem like different catalogs any longer.

Arnei commented 2 months ago

Now they shouldn't seem like different catalogs any longer.

Can confirm, looks good to me now.

I was going to complain that we should not need extra code for rendering start_date, as it is part of the standard metadata catalog and therefore should be able to be rendered just like any other metadata field. But it turns the reason we cannot do that is ultimately the backends fault, as the relevant endpoint (admin-ng/event/new/metadata) explicitly excludes start_date (among other fields). Whether or not this is reasonable likely requires additional consideration, so I'm ok with leaving this as it is for now.

lkiesow commented 2 months ago

Rebased to resolve merge conflicts and fixed the next/previous problem.

lkiesow commented 2 months ago

Rebased to fix resolve conflicts.

The validation for the main metadata is not happening anymore.

Fixed.

Arnei commented 2 months ago

Can confirm, validation is happening again.

But the "Previous" button on the metadata tab does nothing again. Seems to only occur if I want to schedule an event. Here is a video of me clicking around: Bildschirmaufzeichnung vom 2024-07-26, 14-48-04.webm

(Edit: Since my mouse is missing from the recording: The one time I jump back to source, I used the circle buttons instead of the "Previous" button)

github-actions[bot] commented 5 days ago

This pull request has conflicts ☹ Please resolve those so we can review the pull request. Thanks.