opencast / opencast-admin-interface

A modern admin user interface for Opencast
https://admin-interface.opencast.org
Educational Community License v2.0
1 stars 22 forks source link

Allow tracks in event asset upload #698

Open Arnei opened 2 weeks ago

Arnei commented 2 weeks ago

Old logic dictates that media of type track cannot be in the asset upload tab of the event details or new event wizard. Since subtitles are now tracks, this logic finally breaks.

Instead of relying on checking for type track to differentiate between options for source upload and asset upload, this commit instead uses the key in the list provider that is there for this exact purpose.

To review this, you will need an Opencast with Asset Upload configured. Check the Opencast docs on how to do that https://docs.opencast.org/develop/admin/#configuration/admin-ui/asset-upload/#manual-asset-upload. This changes behaviour for both the event details and the create event dialog.

Fixes #694.

github-actions[bot] commented 2 weeks ago

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-698

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-698

It may take a few seconds for the interface to spin up. It will then be available at http://127.0.0.1:3000. For more options you can pass on to the proxy, take a look at the README.md.

github-actions[bot] commented 2 weeks ago

This pull request is deployed at test.admin-interface.opencast.org/698/2024-07-01_07-34-41/ . It might take a few minutes for it to become available.

github-actions[bot] commented 1 week ago

This pull request has conflicts ☹ Please resolve those so we can review the pull request. Thanks.

github-actions[bot] commented 6 days ago

This pull request has conflicts ☹ Please resolve those so we can review the pull request. Thanks.

github-actions[bot] commented 2 days ago

This pull request has conflicts ☹ Please resolve those so we can review the pull request. Thanks.