opencast / opencast-admin-interface

A modern admin user interface for Opencast
https://admin-interface.opencast.org/
Educational Community License v2.0
1 stars 22 forks source link

Disabled buttons need more contrast #641 #723

Open rlucke opened 1 week ago

rlucke commented 1 week ago

add a inactive color for buttons

fixes #641

github-actions[bot] commented 1 week ago

Hi @rlucke Thank you for contributing to the Opencast Editor. We noticed that you have not yet filed an Individual Contributor License Agreement. Doing that (once) helps us to ensure that Opencast stays free for all. If you make your contribution on behalf of an institution, you might also want to file a Corporate Contributor License Agreement (giving you as individual contributor a bit more security as well). It can take a while for this bot to find out about new filings, so if you just filed one or both of the above do not worry about this message! Please let us know if you have any questions regarding the CLA.

github-actions[bot] commented 1 week ago

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-723

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-723

It may take a few seconds for the interface to spin up. It will then be available at http://127.0.0.1:3000. For more options you can pass on to the proxy, take a look at the README.md.

github-actions[bot] commented 1 week ago

This pull request is deployed at test.admin-interface.opencast.org/723/2024-06-20_14-03-14/ . It might take a few minutes for it to become available.

lkiesow commented 1 week ago

I don't think this is a good idea. After your patch you purely rely on color which can also be a problem for people. More than that, the disabled button is not an element which needs or even can be used. I think the low contrast here is intentional. You want to get an inactive element out of the users way after all.

Screenshot from 2024-06-20 19-12-14