opencast / opencast-admin-interface

A modern admin user interface for Opencast

https://admin-interface.opencast.org/

Educational Community License v2.0

1 stars 22 forks source link

Custom roles in ACL policy #729

Open dennis531 opened 1 week ago

dennis531 commented 1 week ago

Changes

Add create option function to dropdown component
Add button "new custom role" to create a policy with a new custom role

Alternative

We could show only one button "new policy" and enable the creation in the dropdown

Screenshot

grafik

Close #658

github-actions[bot] commented 1 week ago

This pull request is deployed at test.admin-interface.opencast.org/729/2024-06-21_11-03-41/ . It might take a few minutes for it to become available.

github-actions[bot] commented 1 week ago

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-729

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-729

It may take a few seconds for the interface to spin up. It will then be available at http://127.0.0.1:3000. For more options you can pass on to the proxy, take a look at the README.md.

Arnei commented 6 days ago

As for the alternative you suggested:

The benefit I see in the additional "New custom role" button is that it serves a a sort of confirmation. Meaning by clicking this button, the user knowingly accepts that their adding roles unknown to the system.
However, not having the button also has its upsides. It means we don't have two dropdowns that look like they should work identically, but don't. Furthermore, dropdowns for custom roles are not "creatable" anymore after closing and opening the event details, meaning if you want to change a custom role later on because of a typo, you cannot change the role directly but have to remove it and create a new one, which can be a bit cumbersome.

Therefore I'm slightly in favor of the no-button alternative, but it's not hard enough of an opinion that I would block this PR.

dennis531 commented 6 days ago

I prefer to have only one button, as the new create dropdown can also be used to select existing ACLs. In my opinion, this separation would rather confuse users and lead to lower usability.

We could also use the create dropdown for editing roles to avoid the workaround of removing policies.