github-actions[bot]
commented
1 week ago Hi @rlucke Thank you for contributing to the Opencast Editor. We noticed that you have not yet filed an Individual Contributor License Agreement. Doing that (once) helps us to ensure that Opencast stays free for all. If you make your contribution on behalf of an institution, you might also want to file a Corporate Contributor License Agreement (giving you as individual contributor a bit more security as well). It can take a while for this bot to find out about new filings, so if you just filed one or both of the above do not worry about this message! Please let us know if you have any questions regarding the CLA.
If elements other than button and anchor should be accessible with the keyboard, set the tabindex. However, this only works reliably if it is set to 0. A sequence with values greater than zero is only possible if the element can be accessed via tab anyway. In most cases, a changed order is difficult to understand for users and difficult to maintain for developers anyway, so I advise against using tabindex. Elements should be natively accessible via tab, then you don't need to set the tabindex to 0.
As a fix I have removed all tabIndex entries for DropDown and made the attribute optional with default 0. This means that the dropdown is always accessible. If necessary, you should consider removing the attribute completely and setting the tabindex to 0.
fixes #598