search

opencast / opencast-admin-interface

A modern admin user interface for Opencast
https://admin-interface.opencast.org/
Educational Community License v2.0
1 stars 22 forks source link

Add a very restricted form of `no-tabs` to the ESLint config #749

Open JulianKniephoff opened 4 days ago

JulianKniephoff commented 4 days ago

This is in preparation to adopting @opencast/eslint-config-ts-react, which includes no-tabs.

We use tabs for indentation in some places, but also for other things. The indentation tabs are easy to get rid of automatically, if a bit annoying. It is the other instances that are not so easily picked out, and especially distinguished from valid tab usages (think literals).

So I'm getting these out of the way first.

github-actions[bot] commented 4 days ago

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-749

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-749

It may take a few seconds for the interface to spin up. It will then be available at http://127.0.0.1:3000. For more options you can pass on to the proxy, take a look at the README.md.

github-actions[bot] commented 4 days ago

This pull request is deployed at test.admin-interface.opencast.org/749/2024-06-26_15-47-52/ . It might take a few minutes for it to become available.

github-actions[bot] commented 1 hour ago

This pull request has conflicts ☹ Please resolve those so we can review the pull request. Thanks.