search

opencast / opencast-docker

Dockerfiles for Opencast
https://quay.io/organization/opencast/
Educational Community License v2.0
41 stars 36 forks source link

Improve of docker-compose multisrv #111

Closed mliradelc closed 5 years ago

mliradelc commented 5 years ago

This is an improvement to the docker compose script made by @mtneug add some explicit declaration and improvements for the database. This PR solves #109 and #110.

- Network Changes - Aliases for docker network now with an explicit declaration - Port 3306 no declared outside to avoid host conflicts.

Docker Initialization - Opencast nodes will wait for ActiveMQ and MariaDB containers to be ready before they start to be deployed.

mliradelc commented 5 years ago

Ok, this is unexpected, Travis is having trouble building Opencast and I don't have an idea why the files I modify are not supposed to be built.

This is the first error from Travis: update-alternatives: error: error creating symbolic link '/usr/share/man/man1/rmid.1.gz.dpkg-tmp': No such file or directory

mtneug commented 5 years ago

This is unrelated to your change. This error started showing up a couple of days ago. My guess is that either the base image or something with the dependencies was changed. I will look into it today.

mtneug commented 5 years ago

Could you also rebase to latest commit? CI should then succeed again.

mliradelc commented 5 years ago

Could you also rebase to latest commit? CI should then succeed again.

Thanks, I added your latest changes.

The biggest issue was the problem with the timeout and the DDL file at the end. You said that the DDL is generated, What is the advantage to use that and put the original opencast DDL file?

And the port, I suggest to leave it closed (Or with an alternative host port).

mtneug commented 5 years ago

If applicable could you adjust docker-compose.allinone.h2.yml, docker-compose.allinone.mariadb.yml, and docker-compose.build.yml as well?

mliradelc commented 5 years ago

If applicable could you adjust docker-compose.allinone.h2.yml, docker-compose.allinone.mariadb.yml, and docker-compose.build.yml as well?

No problem, but I will do another PR keep the topic consistency.

mtneug commented 5 years ago

Thank you looks good now. I created #113 for the other files and will merge this forward to master and 6.4.