search

opencast / opencast-docker

Dockerfiles for Opencast
https://quay.io/organization/opencast/
Educational Community License v2.0
41 stars 36 forks source link

Remove old PID file #65

Closed mtneug closed 6 years ago

mtneug commented 6 years ago

This should fix #61.

mtneug commented 6 years ago

To reproduce the issue one can start an Opencast instance with the docker-compose files and then stop ActiveMQ and MariaDB before Opencast. The stop routine then seems to error leaving the PID file still present.

mtneug commented 6 years ago

It turns out that /opencast/instances/instance.properties is actually used for looking up the PID. Added that file to the removal list.

JanKoppe commented 6 years ago

I'm not really sure if it's a good idea to just remove the PID. Of course, the user should know that only one container should be running at a time, but I can see some weird edge cases happening.

Maybe it would be a better idea to add some command to the start script, which should be manually executed after we display a huge, loud warning when the pid file exists?

JanKoppe commented 6 years ago

My concerns have been resolved in a private chat - this scenario should not occur, therefore the approach is safe.