opencdms-dev / pyopencdms

⭐🐍 pyopencdms aims to build a common Python API on top of multiple Climate Data Management Systems (CDMS) that use different underlying database engines
MIT License
1 stars 2 forks source link

Pygeoapi provider [Completed ] #9

Closed chinedu117 closed 1 year ago

chinedu117 commented 1 year ago

@isedwards @david-i-berry

Please review the changes notably :

david-i-berry commented 1 year ago

In PostGIS we can have mixed geography types in the same column so at this stage I would leave it as a generic geography type. As way of example see a quick test below:

image.png

david-i-berry commented 1 year ago

The geographies in the column need to have the same SRID but we may want to allows SRIDs other than 4326. We can take this question to the TT-CDM but my preference is to be flexible as long as the CRS / SRID is reported in the data model.

chinedu117 commented 1 year ago

The geographies in the column need to have the same SRID but we may want to allows SRIDs other than 4326. We can take this question to the TT-CDM but my preference is to be flexible as long as the CRS / SRID is reported in the data model.

Thanks for the insight. Could we instead enforce SRID 4326 ? We can always convert from one SRID to another using postgis or geoalchemy's ST_Transform method. So we would only expect the srid to be in one format for all our calculations.

david-i-berry commented 1 year ago

The geographies in the column need to have the same SRID but we may want to allows SRIDs other than 4326. We can take this question to the TT-CDM but my preference is to be flexible as long as the CRS / SRID is reported in the data model.

Thanks for the insight. Could we instead enforce SRID 4326 ? We can always convert from one SRID to another using postgis or geoalchemy's ST_Transform method. So we would only expect the srid to be in one format for all our calculations.

That's a good point, in terms of implementation we can insist on 4326 but then provide the mechanism for transformation to other SRIDs.

chinedu117 commented 1 year ago

image

chinedu117 commented 1 year ago

image