Open KronicDeth opened 3 years ago
@KronicDeth Hello, and thank you for sharing this!
I have been experiencing same issue as descrbed in https://github.com/jaegertracing/jaeger/issues/1951.
I tried applying your fix my mix.deps
ing from your branch, but the issue still seems to have persisted for me. I'm assuming you were able to resolve using this on your end?
Fixes jaegertracing/jaeger#1951
Changelog
Bug Fixes
Convert unsigned IDs to signed IDs for Thrift Thrift IDs are i64, which is a signed 64-bit integer, but the Jaeger protocol says IDs are unsigned, so in our records we store them unsigned. When sending the IDs through Thrift, we need to convert the bits directly from unsigned to signed. This matches the behavior in the Python client as pointed out in the bug report triage, but we get to use type specifiers to make it clearer (:tada: Erlang!) instead of bit shifts and masking that Python needs to do.