search

opencensus-beam / opencensus_absinthe

Opencensus integration with Absinthe
Apache License 2.0
20 stars 5 forks source link

Call to_string/1 on location.line to appease Datadog agent #10

Closed sneako closed 5 years ago

sneako commented 5 years ago

Hello and thanks for the lib!

I am trying to use it with the Datadog exporter, but getting the following error: [error] DD: Unable to send spans, DD reported an error: 400: 'json: cannot unmarshal number into Go struct field Span.meta of type string\n'

It appears that the datadog agent expects all of the metadata field values to be strings but the field_line value is currently an int.

codecov-io commented 5 years ago

Codecov Report

Merging #10 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #10   +/-   ##
======================================
  Coverage    8.82%   8.82%           
======================================
  Files           6       6           
  Lines          34      34           
======================================
  Hits            3       3           
  Misses         31      31
Impacted Files Coverage Δ
lib/opencensus/absinthe/middleware.ex 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 05d27d8...0590381. Read the comment docs.

garthk commented 5 years ago

Thanks for the PR! I regret I'm not going to merge it right away. Rather, I've double-checked the spec and raised an issue for the DG adapter.

sneako commented 5 years ago

Thanks for looking in to this. I'll try to get this fixed in the datadog adapter