search

opencensus-beam / opencensus_absinthe

Opencensus integration with Absinthe
Apache License 2.0
20 stars 5 forks source link

Add integration test #17

Open garthk opened 5 years ago

garthk commented 5 years ago

Open for feedback before merging. Anyone got any better ideas than spamming Application.ensure_started/1 in the setup_all to override the runtime: false?

I think Span and SpanCaptureReporter demonstrate opencensus-beam/opencensus_elixir#18 well: why should everyone working with spans have to duplicate either? There's enough noise in the test file just getting Absinthe ready.

codecov-io commented 5 years ago

Codecov Report

Merging #17 into master will increase coverage by 63.36%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #17       +/-   ##
==========================================
+ Coverage   28.94%   92.3%   +63.36%     
==========================================
  Files           6       7        +1     
  Lines          38      39        +1     
==========================================
+ Hits           11      36       +25     
+ Misses         27       3       -24
Impacted Files Coverage Δ
lib/opencensus/absinthe/plug.ex 0% <0%> (ø)
lib/opencensus/absinthe/middleware.ex 95.23% <0%> (+57.14%) :arrow_up:
lib/opencensus/absinthe/acc.ex 75% <0%> (+75%) :arrow_up:
lib/opencensus/absinthe/phase/pop.ex 100% <0%> (+100%) :arrow_up:
lib/opencensus/absinthe.ex 100% <0%> (+100%) :arrow_up:
lib/opencensus/absinthe/phase/push.ex 100% <0%> (+100%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 36ef198...39fbe3e. Read the comment docs.

codecov-io commented 5 years ago

Codecov Report

Merging #17 into master will increase coverage by 63.36%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #17       +/-   ##
==========================================
+ Coverage   28.94%   92.3%   +63.36%     
==========================================
  Files           6       7        +1     
  Lines          38      39        +1     
==========================================
+ Hits           11      36       +25     
+ Misses         27       3       -24
Impacted Files Coverage Δ
lib/opencensus/absinthe/plug.ex 0% <0%> (ø)
lib/opencensus/absinthe/middleware.ex 95.23% <0%> (+57.14%) :arrow_up:
lib/opencensus/absinthe/acc.ex 75% <0%> (+75%) :arrow_up:
lib/opencensus/absinthe/phase/pop.ex 100% <0%> (+100%) :arrow_up:
lib/opencensus/absinthe.ex 100% <0%> (+100%) :arrow_up:
lib/opencensus/absinthe/phase/push.ex 100% <0%> (+100%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 36ef198...39fbe3e. Read the comment docs.