openchargemap / ocm-app

The openchargemap.org web and mobile app
https://map.openchargemap.io
MIT License
42 stars 13 forks source link

Improve Add / Edit charger pages #4

Closed Felger closed 2 years ago

Felger commented 6 years ago

As is, the add/edit pages are difficult to use. Some small modifications would go a long way to making them easier for users to update the charge map. Suggestions:

Felger commented 6 years ago

My apologies if this is the wrong place for this issue, happy to move this to the system project if that's more appropriate.

webprofusion-chrisc commented 6 years ago

@Felger hi, great feedback and revisions to our Add workflow are long overdue. Technically this refers to the 'system' repo as thats where this is currently kept (it's an asp.net mvc website - server side rendering etc). I would however like to move the 'add' process to our app instead so that there is only one codebase to maintain for the add/edit workflow. The app is currently being updated (to ionic 4/angular 6) and would be the same on web, android app and ios app. It's one of the many projects I juggle so if you know any interested developers who could volunteer to help that would be great.

Felger commented 6 years ago

Same as you, I've got a number of projects I'm juggling, but at the very least I'll make it known that you're looking for help on this. Would be great to get the new version of the app all nice and polished.

webprofusion-chrisc commented 6 years ago

@Felger we'll get there one day, and others showing interest does help it along and provide some motivation.

On a tangent, would ABRP possibly have an API we could integrate with? Our current web app has a concept of Journeys (a series of saved waypoints) and sort of does a basic route query but routing in general is not really a priority. At the same time we have over 10k drivers per month who use the app (not a lot, but not insignificant) and it would be great to help them out with better services if the development can be kept to the minimum.

Felger commented 6 years ago

We haven't put much (read: any) work into a public API, but I don't think it'd be out of the question. The problem for you is, to expand our coverage as much as possible, we pull from a ton of different databases, not just OCM, so when we return a route, odds are pretty good that it'll include non-OCM chargers. I'll talk to Bo about whether it'd be worth opening that up, wouldn't be too hard to implement an OCM filter on the planning request.

Speaking of, I still see you missing a lot of the NREL chargers, with so many new chargers popping up, might not be a bad idea to re-incorporate that to a more regular data pull.

razzeee commented 4 years ago

Tried to edit a location and got this. image

I tried to empty the Usage Cost, as that station is for free

razzeee commented 4 years ago

Seems like I also get that when I try to add a new location. Did not get that some days ago.

webprofusion-chrisc commented 4 years ago

@Razzeee thanks, I'm away from a computer just now but I'd suspect the API is returning an error on submit, worth debugging in chrome network tab to see what the response actually is.

webprofusion-chrisc commented 4 years ago

@Razzeee resolved now.