openchargemap / ocm-system

Open Charge Map is the global public registry of electric vehicle charging locations. Established 2011. Help wanted.
https://openchargemap.org
MIT License
102 stars 33 forks source link

Mapping migration: use OSM where practical #112

Closed webprofusion-chrisc closed 1 year ago

webprofusion-chrisc commented 5 years ago

Historically most of the mapping UI (Maps, place searches) has been provided by the Google Maps javacript sdk. As Google Maps now charges for Places searches in particular (and static maps views, dynamic maps to some extent) out API bill would be prohubitively expensive. For that reason biilable API calls need to be moved to an alternative service where possible.

Currently the least expensive option is Apple Maps, so a transition to MapKitJS has begun. The Android and iOS native apps will continue to use Google Maps (an experimental build using MapKitJS prove to slow to use).

Some basic map operations have been transitions and the current plans is now to get the the searches working again.

Once we are back to normal the plan is to implement the main POI Editor (Add/Edit locations) in the app (https://map.openchargemap.io) to favour mobile users and to give us one editor codebase.

beatnickgr commented 5 years ago

If we want the app to be in the F-Droid, we should prefer OpenStreetMap, not Apple...

webprofusion-chrisc commented 5 years ago

@beatnickgr thanks, we can probably offer MapBox (which is OSM data) but I'm not aware of a completely open source native mapping solution and we will still want to offer user the option of choosing Google Maps (we removed Apple Maps from the Android version).

beatnickgr commented 5 years ago

Thanks for your quick answer. We're 2 osm cartographers discussing how to (correctly) map the charging stations, and i want to invite you to our group. I used your app's name for the link because i couldn't find another one available https://t.me/openchargemap

webprofusion-chrisc commented 5 years ago

Thanks, if we could discuss it here that would be great. I have switched the web version of the app over to Mapbox (OSM)

webprofusion-chrisc commented 5 years ago

@beatnickgr on the topic of OSM ev charging here are a few links from past discussions:

https://wiki.openstreetmap.org/wiki/OpenChargeMap

https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dcharging_station

beatnickgr commented 5 years ago

Tag https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dcharging_station is completely outdated. You might see I have edited the discussion page but received no answer. As a faster way of communication, I've joined the OSM telegram group and from there created a separated group for chargers. It would be a pleasure if you joined our informal conversation in that group.

beatnickgr commented 5 years ago

The new group for Electric Vehicles is now listed in the wiki https://wiki.openstreetmap.org/wiki/List_of_OSM_centric_Telegram_accounts

zymurgic commented 5 years ago

Looks like the mapbox api key is giving 401 Unauthorized at the moment

webprofusion-chrisc commented 5 years ago

@zymurgic thanks I changed that a few days ago (MapBox have graciously given us 6 months free, which is great because we've done 124K map view as 30K geocodes in the last 6 days). I suspect your browser is caching the javascript from before the key change?

zymurgic commented 5 years ago

Ah yes. I normally just try in a different browser, but that too had cached the old javascript with the old key as well.

poliantoIT commented 5 years ago

Hi, from some day in the page https://openchargemap.org/site/poi/add the map is blank. Problably it is somting due to the recent changes, can you fix it please? Bye Antonio

webprofusion-chrisc commented 5 years ago

@poliantoit thanks, I'd forgotten that page uses the older API key, I'll get that fixed.

Update: fixed. Interesting that it took 6 days for the issue to be raised though, that suggests our community is not as healthy as it could be (plenty of users, not enough contributors).

poliantoIT commented 5 years ago

Thanks, I noticed it 5 days ago but I thought that it was something on which you were working on so I waited until after Easter to report the issue. ( I've been some days totally offline)

webprofusion-chrisc commented 5 years ago

@poliantoit sorry I wasn't blaming you for not reporting it, I think we have a larger issue with feedback and engagement with the overall community of users.