search

openchargemap / ocm-system

Open Charge Map is the global public registry of electric vehicle charging locations. Established 2011. Help wanted.
https://openchargemap.org
MIT License
108 stars 33 forks source link

UK National Charge Point Registry import is matching BP Pulse (AU) in preference to BP Pulse (UK) #220

Closed zymurgic closed 1 year ago

zymurgic commented 1 year ago

BP Pulse (AU) is a different charging network to BP Pulse (UK), credentials for one don't work on the other.

When matching charging network names against the UK National Charge Point Registry, it should perhaps favour operator name matches with a (UK) suffix over a less appropriate substring match?

This probably also affects other imports for other countries, especially when there's multinational entities branding disjoint networks as though they were one.

Example:

OCM-255435

webprofusion-chrisc commented 1 year ago

Agreed, we also have a direct mapping of Name: OCM-OPERATOR-ID that's a bit less haphazard than the old method of guessing the names, it just doesn't work dynamically when we add new operators to our database.

webprofusion-chrisc commented 1 year ago

As an aside, we only have 6 imports, 3 of which are OCPI feeds - currently my plan would be to retire any other imports as soon as an OCPI feed becomes available as an alternative. I'm pretty sure the US AFDC will move to an OCPI feed sometime as they are proposing to mandate an OCPI feed to them from networks (which is something all countries should have!).

Long term I'd be happy to import only OCPI and even make our main API be an OCPI (locations) output but there's plenty of gaps to fill and in the case of UK CPR we'd have to encourage them to offer an OCPI version of their API (feel free to do that if you know anyone!).

The main problem we have with matching imports to operators currently is we don't get a feed of operators so we have to manually add them to our database and match them as a mapping in code.

webprofusion-chrisc commented 1 year ago

Updated the operator mappings but I see we are also getting null Titles for some times so I'll investigate that and apply some combination of what you suggested in #156

zymurgic commented 1 year ago

It doesn't help that the UK National Chargepoint registry seems to offer charge point operators a bulk import, but offers nothing to aid in automatically synchronising the existing entries with their own systems, so there's a lot of entries in there that are missing important information, like accurate charge connector information; or the entries have long-since been defunct, with charge points that no longer exist, or have been replaced with upgraded equipment.