opencitations / oc_ocdm

Object mapping library for manipulating RDF graphs that are compliant with the OpenCitations datamodel.
https://opencitations.net/
ISC License
3 stars 3 forks source link

Proposal to add time zone to snapshot generation time #15

Closed arcangelo7 closed 1 year ago

arcangelo7 commented 3 years ago

oc-ocdm saves snapshot generation time in "%Y-%m-%dt%H:%M:%S" format, that is without time zone. In a vision of data in federation, where several endpoints manage different entities that call each other in a way compliant with the Opencitations Data Model, the absence of time zone information would be a problem. This would mean not only modifying the implementation, but also modifying the OCDM, in addition to the fact that all the data generated so far do not have the time zone indication. It’s probably not going to be a short-term problem, but I’m still writing an issue to focus on the problem.

arcangelo7 commented 2 years ago

oc_ocdm 7.1.3 generates timezone-aware provenance having UTC as a timezone, to prevent inconsistencies given by the daylight time.

In addition, in the November COCI dump, all provenance was modified by transforming naive times into timezone-aware times in CSV and Nquads format.

However, the OCDM has not been updated yet.

arcangelo7 commented 1 year ago

The OCDM already imposes xsd:dateTime as a range for prov:generatedAtTime and pro:invalidatedAtTime. xsd:dateTime optionally presents the time zone. Thus, there is no need to update the data model