search

opencitations / oc_ocdm

Object mapping library for manipulating RDF graphs that are compliant with the OpenCitations datamodel.
https://opencitations.net/
ISC License
3 stars 2 forks source link

Differences between documentation and code: import_entities_from_graph #4

Closed arcangelo7 closed 3 years ago

arcangelo7 commented 3 years ago

The documentation of the import_entities_from_graph method of the Reader class is out of date. In fact, the method takes three mandatory arguments, not two: the GraphSet, the Graph and the responsible agent. The latter is not mentioned in the documentation. Furthermore, import_entities_from_graph is also invoked by the sync_with_triplestore method of the graph_set module, but it is called without specifying the responsible agent, preventing its use.

iosonopersia commented 3 years ago

Hi @arcangelo7 ! Thank you very much for reporting this problem! I'm going to fix it in the following days. A new version of oc_ocdm will be published as a result. Bye!

iosonopersia commented 3 years ago

Hi @arcangelo7 !

Furthermore, import_entities_from_graph is also invoked by the sync_with_triplestore method of the graph_set module, but it is called without specifying the responsible agent, preventing its use.

This should be fixed in version 5.0.0 . Please, try to upgrade your local version by running the following command:

pip install -U oc_ocdm

As far as the documentation is concerned, I'm going to check it as soon as possible. Bye!

iosonopersia commented 3 years ago

I checked the documentation right and it seems ok!

Perfect!

arcangelo7 commented 3 years ago

I can confirm that it is perfect now, thank you!