opencivicdata / docs.opencivicdata.org

Open Civic Data project documentation
https://open-civic-data.readthedocs.io
44 stars 33 forks source link

0006: Bill feedback #19

Closed jpmckinney closed 10 years ago

jpmckinney commented 10 years ago

Consistency:

Choice of terms:

Here are some suggested terms from the Dublin Core Metadata Terms, which Popolo is likely to adopt in a generic Document class, since they are the most broadly used metadata terms:

Questions:

jamesturk commented 10 years ago

thanks for this!

jamesturk commented 10 years ago

TODOs:

paultag commented 10 years ago

re: from_organization - yeah, it was to let the relationship be described a bit more clearly, since there are many relations that orgs have to bills.

Something like organization_id would be OK if that's what's needed to normalize the spec

jpmckinney commented 10 years ago

Question:

jamesturk commented 10 years ago

Implemented a lot of the changes discussed here. A few documentation clarifications to add, and one or two things left to decide. (@paultag @twneale - chiming in here would be helpful if you have a strong opinion)

paultag commented 10 years ago

Yeah, I'm sold on sponsors -> sponsorships, since it's really talking about the relation, not the entity

As a result, I think this makes classification make a bit more sense, since you're talking about the sponsorship relation's classification, not the sponsor's role in the act of sponsorship

jpmckinney commented 10 years ago

I guess it can go either way. The Membership and Post classes use a role property to describe the role of whoever is a member / holds the post; similarly, sponsorship can describe the role of the person sponsoring. For me, words like "author" and "cosponsor" sound more like roles than classifications.

I'm trying to think of a statement I can make about a sponsorship using the words "cosponsor" and "classification". I can say "Yoda's sponsorship of HB 1 was as a cosponsor" (or more simply, "Yoda sponsored HB 1 as a cosponsor"), or I can ask "What was Yoda's role in sponsoring HB 1?" but saying "Yoda's sponsorship of HB 1 was classified as a cosponsorship" or asking "How was Yoda's sponsorship of HB 1 classified?" seem more clumsy; I also had to switch "cosponsor" to "consponsorship".

Anyway, no strong opinion here, but Membership is an example of a person relating to another entity where role made sense.

jamesturk commented 10 years ago

I think either could work here, and yes trying to use classification is a bit clunky, but it is consistent with how we tend to treat the classification term elsewhere (namely, a different set of options per appearance) and has less confusion with membership.role.

Other than that, I think I've made all discussed changes, on to votes!

jpmckinney commented 10 years ago

Awesome, you can @ mention me in the Vote issue.

One last question that got lost earlier: is it possible to have a name without having an entity_type in sponsors or related_entities? If they always both occur, I may have a change to suggest.

jamesturk commented 10 years ago

Ah- Ideally no, but practically yes.

If we're scraping data and there's a list of sponsors we might get something ambiguous- 'Boss Ribs' - we don't know if that is the Boss Ribs Committee or Ms. Boss Ribs ( http://openstates.org/mt/legislators/MTL000177/forrestina-frosty-calf-boss-ribs/ )

So entity_type can be blank until it is resolved to a specific entity.

On Wed, Jun 18, 2014 at 11:56 AM, James McKinney notifications@github.com wrote:

Awesome, you can @ mention me in the Vote issue.

One last question that got lost earlier: is it possible to have a name without having an entity_type in sponsors or related_entities? If they always both occur, I may have a change to suggest.

— Reply to this email directly or view it on GitHub https://github.com/opencivicdata/docs.opencivicdata.org/issues/19#issuecomment-46455250 .

jpmckinney commented 10 years ago

Thanks for the clarification. The spec has all properties after actions as subproperties of actions - is there an indentation error?

jamesturk commented 10 years ago

ah yes, just saw & fixed this!

ok closing this one out for now