opencivicdata / docs.opencivicdata.org

Open Civic Data project documentation
https://open-civic-data.readthedocs.io
44 stars 33 forks source link

Person/Organization image field source/note #54

Closed jamesturk closed 7 years ago

jamesturk commented 8 years ago

The image field on Person and Organization models are only for a URL string. It seems metadata attributing credit or name of the source for the photo (GPO Member Guide) and a possible note (e.g. "Official Congress Headshot") would provide more complete information about the photo.

via @crdunwel https://github.com/opencivicdata/python-opencivicdata-django/issues/41

jpmckinney commented 8 years ago

I suppose we could have these sources added under sources? Otherwise we might end up having sources for individual properties all over the place.

jamesturk commented 8 years ago

that seems right to me On Sep 25, 2015 10:07, "James McKinney" notifications@github.com wrote:

I suppose we could have these sources added under sources? Otherwise we might end up having sources for individual properties all over the place.

— Reply to this email directly or view it on GitHub https://github.com/opencivicdata/docs.opencivicdata.org/issues/54#issuecomment-143233386 .

jpmckinney commented 7 years ago

If using the existing sources is the way to go, then there is no need to change the OCDEP.

fgregg commented 5 years ago

Right now a source field provides two fields, note and url. Since the person and organization images fields are already urls, is the thinking that we should duplicate the image url into the source url?