opencivicdata / docs.opencivicdata.org

Open Civic Data project documentation
https://open-civic-data.readthedocs.io
44 stars 33 forks source link

Policy for code lists #59

Open jpmckinney opened 8 years ago

jpmckinney commented 8 years ago

To make code list changes easier to review independently, I propose the following policy.

Other issues:


For all lists:

For ORGANIZATION_CLASSIFICATION_CHOICES and BILL_CLASSIFICATION_CHOICES:

For BILL_ACTION_CLASSIFICATION_CHOICES:

fgregg commented 8 years ago

What about judicial organizations? We don't have any one using them, but it seems like they were contemplated since OCD Division include US District Court divisions.

jpmckinney commented 8 years ago

Right now, organizations include parties.

Yes, that's what I mean by "political".

Judicial? Sure. I didn't include as nothing in the code has touched that.

fgregg commented 8 years ago

K. I think we also need some documentation about what these different types of organizations mean. I don't really know what a "Corporation" is in this context, nor do I understand the difference between a "Department" and an "Agency"

jpmckinney commented 8 years ago

It often just comes down to what the organization's official name is. A jurisdiction may have an explanation for the difference between boards, committees, commissions, etc. but those definitions will vary between jurisdictions.

fgregg commented 8 years ago

So your proposal is to use the local name, and not to map organization types into cross-jurisdictional taxonomy?

On Sun, Feb 21, 2016 at 11:54 AM, James McKinney notifications@github.com wrote:

It often just comes down to what the organization's official name is. A jurisdiction may have an explanation for the difference between boards, committees, commissions, etc. but those definitions will vary between jurisdictions.

— Reply to this email directly or view it on GitHub https://github.com/opencivicdata/docs.opencivicdata.org/issues/59#issuecomment-186873755 .

773.888.2718

jpmckinney commented 8 years ago

Do you have a plan for how to do that? We can get some of the way there with the top-level organizations, but I don't think it's possible once you dig deeper into the org-tree.

fgregg commented 8 years ago

Right now, the best idea I have would be to require documentation of what the classifications mean and be thoughtful about merging pull requests.

On Sun, Feb 21, 2016 at 12:03 PM, James McKinney notifications@github.com wrote:

Do you have a plan for how to do that?

— Reply to this email directly or view it on GitHub https://github.com/opencivicdata/docs.opencivicdata.org/issues/59#issuecomment-186875188 .

773.888.2718

jpmckinney commented 8 years ago

Added to top of issue description. This issue is to describe what being thoughtful should entail.