search

opencivicdata / docs.opencivicdata.org

Open Civic Data project documentation
https://open-civic-data.readthedocs.io
44 stars 33 forks source link

Filling out Elections proposal #63

Closed gordonje closed 7 years ago

gordonje commented 7 years ago

Moving this PR to the right repo, which I originally made on datamade's fork.

We've essentially borrowed everything from the VIP XML spec that feels useful for the campaign finance use cases. Differences between proposed OCD data types and VIP elements are noted below.

This proposal doesn't include modeling election results (which also aren't in VIP). Will cover that in a future proposal.

@aepton: Saw your comments on the original PR. Have made a few changes based on them and will run through each of your comments. If you feel like I don't adequetely address your concerns, do you mind moving those comments over to this PR? Sorry for the redundant work!

@fgregg, @palewire and @dwillis and whoever else: Please give it look!

jpmckinney commented 7 years ago

@gordonje Can you squash the commits into one?

jpmckinney commented 7 years ago

Closing in favor of #64

gordonje commented 7 years ago

@jpmckinney please forgive my git clumsiness. I've just attempted to squash all the commits via git rebase, but it seems now there are a bunch of other changes to files I never intended to touch. Went ahead and made a new PR (#64) from our own fork of this repo.