Campaign Finance Filing: Review attribute updates

opencivicdata / docs.opencivicdata.org

Open Civic Data project documentation

https://open-civic-data.readthedocs.io

44 stars 33 forks source link

Campaign Finance Filing: Review attribute updates #68

Closed jpmckinney closed 7 years ago

jpmckinney commented 7 years ago

It's not clear that CommitteeStatusUpdate can't be rolled into CommitteeAttributeUpdate - just add description to CommitteeAttributeUpdate.

Also, the class name already establishes the semantics, so I'd change attribute_to_update to property and new_attribute_value to value.

jpmckinney commented 7 years ago

Ping @aepton

aepton commented 7 years ago

Oh my god, sorry, I knew I was procrastinating but yeesh. Especially since I nagged y'all about approving my proposal ;) Sorry sorry! Just submitted a PR that fixes this and addresses some of the issues in the other...issue as well.