opencivicdata / docs.opencivicdata.org

Open Civic Data project documentation
https://open-civic-data.readthedocs.io
44 stars 33 forks source link

Allow people to be responsible for bill actions #83

Open fgregg opened 7 years ago

fgregg commented 7 years ago

Right now, all bill actions have an organization attribute

organization, organization_id ____The organization that this action took place within.

This seems not quite right for the actions of 'signing' or 'vetoing' done by the executive.

Here are the two ways, I've approached this. Neither seem quite right to me.

            bill_action = {'description' : 'Veto',
                           'date' : action_date,
                           'organization' : 'Office of the Mayor',
                           'classification' : 'executive-veto')

I don't really like this approach because the mayor is not the one vetoing legislature because he holds a position in the office of the mayor. He can do it because he is the mayor of the "City of Chicago".

So this is my current approach.

            bill_action = {'description' : 'Veto',
                           'date' : action_date,
                           'organization' : 'City of Chicago',
                           'classification' : 'executive-veto',
                           'related_entitites = [{'name' : 'Rahm Emanuel, 'entity_type': 'person'}                          

I like this better, but "City of Chicago" also doesn't quite seem like the right container.

I think I would like the following to be legal, note the absence of organization"

            bill_action = {'description' : 'Veto',
                           'date' : action_date,
                           'person' : 'Rahm Emanuel',
                           'classification' : 'executive-veto')

Thoughts?

jpmckinney commented 7 years ago

I wasn't involved in authoring the Bill spec so paging @jamesturk

jamesturk commented 7 years ago

sorry, missed this, I think this makes sense & could be implemented using RelatedEntityBase without much trouble