Closed jamesturk closed 7 years ago
Thanks for the review, keeping things named date is fine with me. I updated the proposal to withdraw that, do you think a change to Event's start_time,end_time to bring it in sync w/ everything else makes sense then?
Also, I haven't included this but I wonder if other date fields would benefit from optional times. Looking over the list I can't think of any reasons why that might be the case right now (birth hour?), but I wonder if there is a case to be made for consistency.
Also, I haven't included this but I wonder if other date fields would benefit from optional times. Looking over the list I can't think of any reasons why that might be the case right now (birth hour?), but I wonder if there is a case to be made for consistency.
In Popolo, I had allowed Membership to have optional time components, but I don't remember a compelling reason. (I mean, I suppose there is a specific time at which members are made official, or at which a person dies, but in practice I can't think of a use case where it matters.)
updated to take the above into consideration, and assigned a number
if there are no objections in the next couple of days I think we'll consider this accepted
if you have concerns or want more time to review please comment soon :)
LGTM
deals with opencivicdata/python-opencivicdata#87 and some other nagging time-related issues in the hopes of fixing a few at once
cc @fgregg @jpmckinney