search

opencivicdata / ocd-division-ids

Open Civic Data Division IDs definition & canonical repository
Other
157 stars 93 forks source link

Added 10 new seats for the Japan #342

Closed MarcinMisztalTR closed 1 year ago

MarcinMisztalTR commented 1 year ago

Hello, According to https://en.wikipedia.org/wiki/Next_Japanese_general_election there will be 10 new seats introduced in Japan for that election: Tokyo-26th Tokyo-27th Tokyo-28th Tokyo-29th Tokyo-30th Kanagawa-19th Kanagawa-20th Saitama-16th Aichi-16th Chiba-14th

Please let me know if more details are needed. Thank you.

MarcinMisztalTR commented 1 year ago

I would suggest adding a validFrom column and adding 2025 to the new districts as it looks like the changes aren't in effect until after the election some time in 2025. It also looks like 10 districts are going to be eliminated so consider adding a validThrough column with the year 2025 to the districts that are being removed. https://open-civic-data.readthedocs.io/en/latest/proposals/0002.html#:~:text=has%20multiple%20identifiers.-,validThrough,-The%20date%20on

Hello, Thank you for response. I've added validFrom (set to 2025) for:

and validThrough (set to 2025) for:

jloutsenhizer commented 1 year ago

This looks good overall.

I'm not sure if we should have the 2025 date set for validFrom and validThrough since, as I understand it, the next election where these changes take effect could happen before 2025 if the government is dissolved:

@jpmckinney Any thoughts here?

jpmckinney commented 1 year ago

@jloutsenhizer Yes, we typically set the validFrom/validThrough to the election date.

One option is to not add the new boundaries (and not set validThrough dates on the soon-to-be removed boundaries) until an election date is set.

MarcinMisztalTR commented 1 year ago

Hello, Please let me know what your preferences are: should I leave the dates as they are now or remove them?

jpmckinney commented 1 year ago

If you need to add the future districts, then you need to keep the validFrom - otherwise they are interpreted as already being valid.

If you can wait, then see my above suggestion.

MarcinMisztalTR commented 1 year ago

Hello, I've removed validThrough values from single_member_constituencies.csv (and country-jp.csv). Current state is:

validFrom (set to 2025) for:

jpmckinney commented 1 year ago

Looks good. Yes, once a date is set, we can add precision to validFrom, and fill in validThrough.