search

opencivicdata / ocd-division-ids

Open Civic Data Division IDs definition & canonical repository
Other
153 stars 92 forks source link

Add Districts MX #359

Closed RodrigoRibeiroSantos closed 5 months ago

RodrigoRibeiroSantos commented 7 months ago

Including missing districts from Mexico

jloutsenhizer commented 6 months ago

@RodrigoRibeiroSantos are there any updates on this?

RodrigoRibeiroSantos commented 6 months ago

@RodrigoRibeiroSantos are there any updates on this?

Hi, we are finishing checking the removed districts. I will update the PR until this week.

RodrigoRibeiroSantos commented 6 months ago

@RodrigoRibeiroSantos are there any updates on this?

@jloutsenhizer Hi, I just updated the districts removed. Thanks

jloutsenhizer commented 6 months ago

I left one more comment to correct around validThrough on the new districts. Otherwise this is close. Once you fix that make sure you also run complie.py again so that country-mx.csv gets updated.

@jpmckinney FYI for second review

jpmckinney commented 6 months ago

I reviewed, and can approve once the error is corrected.