search

opencivicdata / ocd-division-ids

Open Civic Data Division IDs definition & canonical repository
Other
157 stars 93 forks source link

Indonesia OCD ID Rename #362

Closed mayanksahu123 closed 10 months ago

mayanksahu123 commented 11 months ago

Hi Zohour,

This Pull Request contains below changes for Indonesia,

1.Renamed the following constituency (Bangka Belitung, Sumatra Barat 1, Sumatra Barat 2, Sumatra Selatan 1, Sumatra Selatan 2, Sumatra Utara 1, Sumatra Utara 2, Sumatra Utara 3) in dewan_perwakilan_rakyat.csv, country-id.csv & added them in alias.csv

2.Renamed the following constituency ( Yogyakarta, Jakarta Raya) in regions.csv, country-id.csv & added them in alias.csv

azuser commented 11 months ago

Hello,

mayanksahu123 commented 10 months ago

Hi @azuser

  • Can you please reorder the ids ?
  • Why did you update special_region to daerah_istimewa ?
  • Can you update the readme with the official sources you used to rename the electoral districts ?
  1. I have reordered the ids by OCDID.
  2. I have corrected this in regions.csv and country-id.csv
  3. I have updated the source in readme.
azuser commented 10 months ago

The current change looks good to me. But I cannot approve it.

@jloutsenhizer can you please have a look ?