search

opencivicdata / ocd-division-ids

Open Civic Data Division IDs definition & canonical repository
Other
157 stars 93 forks source link

update DE constituencies for 2025 snap election #394

Open zikowang opened 6 days ago

zikowang commented 6 days ago

Adding README

Why we propose to change the ocd_paths back using names instead of numbers

  1. while updating the ocd_paths we discovered that 184 constituency numbers changed while they actually staying the same. It was triggered by one change.
  2. also we have 6 valid through and 6 valid from constituencies that keeps the number but is actually different (with a different name).
  3. to keep backward compatibility we added entries to the aliases.csv file

We can not build the new country CSV file because the alias file has chains

Example:

sameAs chain: ocd-division/country:de/land:bb/wahlkreis:brandenburg_an_der_havel_~_potsdam-mittelmark_i_~_havelland_iii_~_teltow-fläming_i -> ocd-division/country:de/ed:60 -> ocd-division/country:de/ed:brandenburg_an_der_havel_-_potsdam-mittelmark_i_-_havelland_iii_-_teltow-fläming_i

How can we proceed from here, since the election is near and we need those OCDs to official.

Best,

zikowang commented 6 days ago

Dear @jloutsenhizer @jpmckinney ,

can you please have a quick look, maybe we can figure out a solution for germany.

jloutsenhizer commented 6 days ago

RE sameAs chain issue. For any of these, I'd recommend updating the old alias to point to whatver is at the end of the chain.

So in the example you shared, it looks like we should update ocd-division/country:de/land:bb/wahlkreis:brandenburg_an_der_havel_~_potsdam-mittelmark_i_~_havelland_iii_~_teltow-fläming_i to be sameAs ocd-division/country:de/ed:brandenburg_an_der_havel_-_potsdam-mittelmark_i_-_havelland_iii_-_teltow-fläming_i

zikowang commented 6 days ago

Thank you for the reply,

When we update the sameAs entry for ocd-division/country:de/land:bb/wahlkreis:brandenburg_an_der_havel_~_potsdam-mittelmark_i_~_havelland_iii_~_teltow-fläming_i

we would lose the ocd-division/country:de/ed:60 in between, so that those paths would be invalid from now on.

Will that be a problem? If not, I am happy to adjust all those chain entries in the aliases file.

jloutsenhizer commented 6 days ago

That should be fine, aliases are meant to be transitive, so the check that's failing is making sure that there isn't unnecessary chaining to get to the canonical OCD ID

zikowang commented 6 days ago

Okay, I cleaned up the aliases file and compiled the country-de.csv file.

Please have a look at the results.