search

opencivicdata / pupa

framework for scraping legislative/government data
BSD 3-Clause "New" or "Revised" License
85 stars 42 forks source link

Allow event location to be null #312

Closed hancush closed 3 years ago

hancush commented 6 years ago

Hi there!

There are some cases where an event is created with a time and date, but the location is TBD.

The OCD standard is slightly ambiguous on whether an Event can have no location (allowing for null, but labeling location a required field):

location (object, null) Where the event will take place. (required)

If null is acceptable, though, it would be great if this were reflected in the pupa.scrape event location schema.

https://github.com/opencivicdata/pupa/blob/c0dbe820821caa66f1cb02675dfdcd3df22307b7/pupa/scrape/schemas/event.py#L43-L47

Thanks for all you do!

fgregg commented 6 years ago

To chime in here, if this change was acceptable to @jamesturk and others, we'd be happy to make the PR.

jamesturk commented 6 years ago

Seems fine to me :)

On Fri, Apr 13, 2018, 16:46 Forest Gregg notifications@github.com wrote:

To chime in here, if this change was acceptable to @jamesturk https://github.com/jamesturk and others, we'd be happy to make the PR.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/opencivicdata/pupa/issues/312#issuecomment-381256423, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAfYt23MJoYzb-8RXgHjD5NI6WfOs0Yks5toQ62gaJpZM4TURUM .

hancush commented 3 years ago

Added in #334 and #335.