search

opencivicdata / pupa

framework for scraping legislative/government data
BSD 3-Clause "New" or "Revised" License
85 stars 42 forks source link

let scraper set date of an eventdocument and eventmedia #324

Closed fgregg closed 4 years ago

fgregg commented 4 years ago

EventDocument and EventMedia both have date attributes.

I'm not sure what the intent of that attribute is, but it would be convenient for me to use it store the publication date of the the document and media.

However, the relevant methods on the event scraper do not have an argument for setting the date.

https://github.com/opencivicdata/pupa/blob/fd599b7fa82059f2ef94bce432dada193bbfdd6c/pupa/scrape/event.py#L123-L130

@jamesturk, is this by design? If not, I'll make a PR adjusting these methods.

jamesturk commented 4 years ago

PR would be great, we pretty much stopped using event stuff, so anything you want to do is fine with me

On Tue, Oct 15, 2019, 7:48 AM Forest Gregg notifications@github.com wrote:

EventDocument and EventMedia both have date attributes.

I'm not sure what the intent of that attribute is, but it would be convenient for me to use it store the publication date of the the document and media.

However, the relevant methods on the event scraper do not have an argument for setting the date.

https://github.com/opencivicdata/pupa/blob/fd599b7fa82059f2ef94bce432dada193bbfdd6c/pupa/scrape/event.py#L123-L130

@jamesturk https://github.com/jamesturk, is this by design? If not, I'll make a PR adjusting these methods.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/opencivicdata/pupa/issues/324?email_source=notifications&email_token=AAAB6YUR3UWLAD4OPFHPED3QOWUYJA5CNFSM4JA3NITKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HR3ELOA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAB6YWFYYQ6IMY5LCUSAY3QOWUYJANCNFSM4JA3NITA .