This PR closes #324 by allowing a date to be set on add_media_link and add_document methods of the Event scraper class.
This doesn't come with tests, but it doesn't quite feel like it needs tests since the underlying _add_associated_link method is already tested.
I've also fixed up the schema for fuzzy_date_blank which had a bad regex and which also permitted datetimes. This does seem like something that we might want to test, but we don't have any tests for schemas that I could find.
jamesturk
commented
4 years ago
This PR closes #324 by allowing a date to be set on
add_media_linkandadd_documentmethods of the Event scraper class.This doesn't come with tests, but it doesn't quite feel like it needs tests since the underlying _add_associated_link method is already tested.
I've also fixed up the schema for fuzzy_date_blank which had a bad regex and which also permitted datetimes. This does seem like something that we might want to test, but we don't have any tests for schemas that I could find.
Please advise @jamesturk .