preliminary django 2.0 compatibility

opencivicdata / python-opencivicdata

python utilities for Open Civic Data

BSD 3-Clause "New" or "Revised" License

34 stars 27 forks source link

preliminary django 2.0 compatibility #109

Closed jamesturk closed 6 years ago

jamesturk commented 6 years ago

need to add on_delete to every FK/OTO field

default is CASCADE, which is behavior in Django 1.x, wherever I diverged from that I commented on why as there are a few cases where SET_NULL makes sense (unresolving entities) and a few cases where it seemed wise to use PROTECT (which will make accidental deletions of entire Jurisdictions/etc.)

@gordonje - I took a rough pass at the elections models but if you want to tweak them feel free to do so

coveralls commented 6 years ago

Coverage decreased (-0.0009%) to 98.999% when pulling a902893c16ac16653c49e0391527c63e9bb47b20 on django2.0 into 648e42d511fee3989dfb69fe43723ec9e36ad97d on master.

jamesturk commented 6 years ago

coveralls issue is a rounding error, this is ready to merge if there are no objections

coveralls commented 6 years ago

Coverage decreased (-0.0009%) to 98.999% when pulling 93c1c5aa7336a9d83eddc945d05d08ced53174ef on django2.0 into ae724bc6c793bc024f869c1aebe1ea685b090769 on master.