Implement !loadbeforeele (with alias !eleload)

opencj-dev / server-gsc

OpenCJ serverside GSC files

GNU Affero General Public License v3.0

3 stars 1 forks source link

Implement !loadbeforeele (with alias !eleload) #136

Open Yocairo opened 2 years ago

Yocairo commented 2 years ago

Find latest save that did not have elevators enabled
In order to not have GSC spam C commands, better to implement this in C code
Ensure loading back to this position clears eleOverrideEver flag
Ensure loading back to another position that allows elevators will have eleOverrideEver flag set

iznogod commented 2 years ago

Latest save that did not have elevators enabled will be the previous one most likely, unless !loadbeforeele value has changed
wasnt the elevate callback called only once per ele start and ele stop?
Disagree, if the previous position did have eleoverride enabled it should be safe to load back to it since eles were allowed back then (just load back to whichever position and set the ele-override as it was back then)
Keep in mind that ele callback is not in sync with serverframes, so the loadposition command will waittillframeend;

iznogod commented 2 years ago

Save amount of elevators in player save. Should not be able to !eleload when any elevates (with !ignoreele on) have been done. Otherwise we can just load back to the previous save since that should be safe. Previous save in this case is the last LOADED save, not the last MADE save.

Yocairo commented 2 years ago

"Should not be able to !eleload when any elevates (with !ignoreele on) have been done." The point of !eleload is that you can load back to a save that didn't have an ele, so I disagree with this part.

iznogod commented 2 years ago

have been done = excluding the current one. If a player bypassed the !eleload earlier, he should not be able to enable !eleload now since the script will have to search quite a few saves to find a non-elevated one.

Yocairo commented 2 years ago

Yeah that's the point of eleload, to find the latest save where no ele had been done. If we don't implement that, !eleload is pointless