search

opencleveland / RTAHeatMap

Python Scripts to generate the distance and time to walk to the nearest public transportation stop in Cuyahoga County and then represent this data as an isochrone map.
MIT License
10 stars 14 forks source link

added close_stop.py #3

Closed Takuya-Sakaguchi closed 8 years ago

Takuya-Sakaguchi commented 8 years ago

Add one simple function to return close bus stops as a panda dataframe. You can simply len() to count the number of stops close by.

Takuya-Sakaguchi commented 8 years ago

Generated CSV files containing 300,000 spots.

mbramson commented 8 years ago

Takuya, a few things:

1) please you put this in a subdirectory of DataGeneration as its sort of a utility, and not necessarily an integrated part of the package at this point (we can integrate it after). I'd like to keep things organized.

2) can you untrack that 300k line .csv? Although not a huge file, that's something that should probably go in the slack channel.

3) And could you revert your change to the .gitignore? Having *.csv in the .gitignore is super useful for testing this thing as .csv's tend to accumulate. In the future, if you need to add something to a repository that cannot be added normally because of a .gitignore, you can add it anyway with "git add -f ".

mbramson commented 8 years ago

Could you remove the 300k line .csv file from the request? We don't need a file of that size and it doesn't really serve a purpose as far as I can tell.

Also, have you taken a look at UniformMapGenerator in DataGeneration? It seems to do something very similar to what you're doing in close_stop.py. What is the purpose of close_stop.py?