openclimatefix / Elexonpy

Python package wrapper around Elexon api
MIT License
4 stars 2 forks source link

return pandas #42

Open peterdudfield opened 1 month ago

peterdudfield commented 1 month ago

Detailed Description

It would be great to have an option to return a pandas dataframe

Possible Implementation

braddf commented 3 weeks ago

Hey hey – just chatting to @14Richa and I'm not 100% on the need to do this within the library itself? It seems just as convenient to call pd.DataFrame(data) at the point of consumption, e.g. in our API that uses this library, as presumably we're importing pandas anyway, and might be doing other data processing/vis stuff with it... rather than adding any complexity to this fairly clean generated (and generate-able) client library.

Maybe hold fire until you can clarify @peterdudfield?

peterdudfield commented 3 weeks ago

This repo - https://github.com/SheffieldSolar/PV_Live-API has a nice function where by default it returns a dataframe. I think its a nice function to have

You might be able to set response_type and see if it works, or adjust the code a bit to work for that

It might be easier to add something to the 'format' query param and then have an option to not return as pandas dataframe.