openclimatefix / MetOfficeDataHub

Python wrapper around MetOffice Atmospheric Model Data REST API
MIT License
3 stars 0 forks source link

Post Process NWP data #15

Closed peterdudfield closed 2 years ago

peterdudfield commented 2 years ago

Detailed Description

Currently Historic data is has some processing done in here

We could also do this processing in this repo when saving the data.

Context

questions?

  1. Is this the right place for processing NWP data?
  2. Could keep this library very clean and move out the application to a different repo. This would be responsible then just of downloading the data files
  3. Could move the processing into nowcasting_dataset, and process the data when loading live data - dont to this for historic
  4. Could combine this repo and NWP and then we can use the same 'processing' code
peterdudfield commented 2 years ago

My potential solution is

What do you two thing, @JackKelly and @jacobbieker

jacobbieker commented 2 years ago

I like 4, in terms of then it similar to Satip that has a nice wrapper for the API to just get data, and then some nice processing code as well if people want that too, and keeps it in one place.

JackKelly commented 2 years ago

Yeah, I agree, I like option 4 as well, for the reasons that you guys cite :slightly_smiling_face:

peterdudfield commented 2 years ago

I bought the code in for the NWP repo, but left NWP repo as is. I didnt want to break that repo. I think this is good enough for now.