openclimatefix / MetOfficeDataHub

Python wrapper around MetOffice Atmospheric Model Data REST API
MIT License
3 stars 0 forks source link

run one order id #20

Closed peterdudfield closed 1 year ago

peterdudfield commented 2 years ago

Detailed Description

Add option to add order id, (or order ids) rather than serarching for all the order ids

Context

Would be good to just run app on one order id. People many have serval orders under one account.

Task Breakdown

peterdudfield commented 1 year ago

Once this is once, we can have both a development and a production one

devsjc commented 1 year ago

@peterdudfield For this, we've two behaviour options that could occur when no order ID's are manually supplied as input:

  1. Download all latest files from all order IDs (current behaviour)
  2. Download nothing

Is one or the other preferable?

peterdudfield commented 1 year ago

@peterdudfield For this, we've two behaviour options that could occur when no order ID's are manually supplied as input:

  1. Download all latest files from all order IDs (current behaviour)
  2. Download nothing

Is one or the other preferable?

Hmm, I'm not sure now. Maybe 1., means there are not breaking changes. But 2. ensures better protection. Lets do 2, and we can always role back if there is a problem

devsjc commented 1 year ago

Alright, I'll make that change.

peterdudfield commented 1 year ago

Ive added (small) details for tasks 2. (AWS secret) and 3. (terraform)

devsjc commented 1 year ago

Dev

devsjc commented 1 year ago

Dev

Merge request for pasing secret to container in terraform https://github.com/openclimatefix/nowcasting_infrastructure/pull/148

devsjc commented 1 year ago

Dev

Update to NWP version number terraform variable

devsjc commented 1 year ago

Looks like it's worked in dev, so far as I can tell anyway. Is there a process beyond that for being comfortable with pushing through to live?

peterdudfield commented 1 year ago

Looks like it's worked in dev, so far as I can tell anyway. Is there a process beyond that for being comfortable with pushing through to live?

No really. Trying to keep things as stream line as possible. Is there are reason we shouldnt push this to live. Perhaps waiting 1 day is reasonable, and if you did it yesterday then should be fine today on live.

devsjc commented 1 year ago

If you've not seen anything break in dev since yesterday there's no reason this can't go through in my book! It looked to be working from my perspective, but I wouldn't necessarily trust my judgement on that all the way for the moment since I've only just started: could be something I don't know about somewhere that isn't working...!

devsjc commented 1 year ago

Prod

Merge request for pasing secret to container in terraform https://github.com/openclimatefix/nowcasting_infrastructure/pull/149

devsjc commented 1 year ago

Prod

devsjc commented 1 year ago

Prod

Update to NWP version number terraform variable