openclimatefix / MetOfficeDataHub

Python wrapper around MetOffice Atmospheric Model Data REST API
MIT License
3 stars 0 forks source link

fix, dont alwasy use dswrf #40

Closed peterdudfield closed 2 years ago

peterdudfield commented 2 years ago

Pull Request

Description

Fix for adding x and y. The bug was it always used dswrf

Fixes # https://github.com/openclimatefix/nowcasting_data_visualization/issues/32

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

Checklist:

codecov-commenter commented 2 years ago

Codecov Report

Merging #40 (2e0deea) into main (7021cf2) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #40   +/-   ##
=======================================
  Coverage   93.31%   93.31%           
=======================================
  Files           6        6           
  Lines         329      329           
=======================================
  Hits          307      307           
  Misses         22       22           
Impacted Files Coverage Δ
metofficedatahub/utils.py 100.00% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more