save to s3 and then rename

[peterdudfield]

Pull Request

Description

Raise condition, when saving to s3, and downloading at the same time, it creates a problem

• To solve this a bit, we
• first upload to s3 and then rename

Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• [ ] Yes

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

• [ ] Yes

Checklist:

• [ ] My code follows OCF's coding style guidelines
• [ ] I have performed a self-review of my own code
• [ ] I have made corresponding changes to the documentation
• [ ] I have added tests that prove my fix is effective or that my feature works
• [ ] I have checked my code and corrected any misspellings

[codecov-commenter]

Codecov Report

Merging #42 (4106aa3) into main (2a65810) will increase coverage by 0.08%. The diff coverage is 100.00%.

:exclamation: Current head 4106aa3 differs from pull request most recent head a62dd9f. Consider uploading reports for the commit a62dd9f to get more accurate results

@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   93.31%   93.39%   +0.08%     
==========================================
  Files           6        6              
  Lines         329      333       +4     
==========================================
+ Hits          307      311       +4     
  Misses         22       22              

Impacted Files	Coverage Δ
metofficedatahub/multiple_files.py	93.00% <100.00%> (+0.20%)	:arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[peterdudfield]

https://github.com/all-contributors please add @jacobbieker for review

[peterdudfield]

@all-contributors please add @jacobbieker for review

[allcontributors[bot]]

@peterdudfield

@jacobbieker already contributed before to review