openclimatefix / MetOfficeDataHub

Python wrapper around MetOffice Atmospheric Model Data REST API
MIT License
3 stars 0 forks source link

Pass order IDs through to download_all_files #49

Closed devsjc closed 1 year ago

devsjc commented 1 year ago

Pull Request

Description

Enables specification of order id(s) to arguments. See #20

Fixes #

How Has This Been Tested

Order ID passing tests are already implemented in test_multiple_files.py

Checklist:

peterdudfield commented 1 year ago

I can see there are some errors due to a pathy upgrade, ill do a seperate PR to fix them

codecov-commenter commented 1 year ago

Codecov Report

Merging #49 (438ffcc) into main (3127fb5) will decrease coverage by 0.05%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   93.41%   93.35%   -0.06%     
==========================================
  Files           6        6              
  Lines         334      331       -3     
==========================================
- Hits          312      309       -3     
  Misses         22       22              
Impacted Files Coverage Δ
metofficedatahub/base.py 88.88% <ø> (ø)
metofficedatahub/app.py 87.09% <100.00%> (+0.43%) :arrow_up:
metofficedatahub/multiple_files.py 92.85% <100.00%> (-0.20%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more